Add localization for UI strings in Simplified Chinese #11723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepankuzmin
added
the
skip changelog
AdaXL
suggested changes
Apr 11, 2022
AdaXL
reviewed
Apr 11, 2022
pengdev
reviewed
Apr 12, 2022
Co-authored-by: Ada <[email protected]> Co-authored-by: Peng Liu <[email protected]>
AdaXL
approved these changes
Apr 12, 2022
| "GeolocateControl.LocationNotAvailable": "位置不可用", | ||
| "LogoControl.Title": "Mapbox 徽标", | ||
| "Map.Title": "地图", | ||
| "NavigationControl.ResetBearing": "将方位重置为北", |
There was a problem hiding this comment.
What does Bearing mean?
The Chinese translation means "Reset the location to North"
There was a problem hiding this comment.
@Jing-flyloveyin Bearing is the direction you're facing.
For you reference, this is the original English strings to compare with https://github.com/mapbox/mapbox-gl-js/blob/main/src/ui/default_locale.js
Also, #11733 for more context.
stepankuzmin
added a commit
that referenced
this pull request
May 20, 2022
stepankuzmin
added a commit
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
This PR adds translations for UI strings we use in GL JS into Simplified Chinese. We translated the UI strings automatically using the Google Translate API, and we need to verify that the translation is correct.
To help us verify the translations, you can open the
Files changedtab on this page and compare the translations with the original filesrc/ui/default_locale.js.If the translation looks good, you can approve it using the
Review changesbutton in theFiles changedtab and selecting theApproveradio button when submitting the review.To improve the machine translation, you can click the plus sign next to the line you want to enhance and select the suggestion button on the toolbar.
After making the suggestions, you can mark the review as finished using the
Review changesbutton and selecting theRequest changesradio button.Thanks for helping 🙌